search

YunoHost-Apps / piwigo_ynh

Piwigo package for YunoHost
http://piwigo.org/
GNU General Public License v2.0
6 stars 4 forks source link

Protect with fail2ban (closes #8) #9

Closed JimboJoe closed 7 years ago

maniackcrudelis commented 7 years ago

Seems good to me, but on which part of this PR would you like my review ? Fail2ban ?

JimboJoe commented 7 years ago

Yes, fail2ban and naming, directory setting conventions... to be compared to this, for example.

maniackcrudelis commented 7 years ago

All seems good. But, we need to test if that works well.

And, I'll glad to see this as an helper instead. But, first, we should try it.

JimboJoe commented 7 years ago

I've tested this, and it indeed works! ;-) As for the helper, I don't see it as a very "smart" one because, besides copying the 2 right files (replacing the app name) and restarting the fail2ban service, I think the configuration can be very different from one app to another one...

maniackcrudelis commented 7 years ago

I think really we can make a simple helper, because we have only to change the failregex and the log. That's all. In the most case, that should works.

And, it can be a good thing if we can expand this to all our apps.

JimboJoe commented 7 years ago

Yep, I see what you mean: in most cases for HTTP(S) ports, configuration files will look alike. I'll try to come up with something!