YunoHost-Apps / pixelfed_ynh

The federated image shareing service Pixelfed for YunoHost
https://pixelfed.org/
GNU Affero General Public License v3.0
44 stars 15 forks source link

Testing : v0.11.2 + php 7.4 #163

Closed lapineige closed 2 years ago

lapineige commented 2 years ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

lapineige commented 2 years ago

Do we need to run the CI again ? (it's the very same version)

Should we only wait a few days to make sure people had some time to test it ?

yalh76 commented 2 years ago

I love running the CI ^^

!testme

yunohost-bot commented 2 years ago

:carousel_horse: Test Badge

lapineige commented 2 years ago

Well I didn't want to put some extra load on the CI while it was the exact same version :sweat_smile: (I launched a call for testing btw, better sure than sorry on this one)

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:carousel_horse: Test Badge

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Meow :cat2: Test Badge

jchammons commented 2 years ago

I just wanted to add that this works perfectly for my on my production instance. Thank you!

lapineige commented 2 years ago

I received 5 positive feedbacks on this PR, either for fresh installs or upgrades. And only one negative one, that was not related to this upgrade. It also fixes #160.

Then I consider it's ready to be merged.

Thanks @yalh76 for you work and to all testers :)