Admin settings do not save correctly

YunoHost-Apps / pixelfed_ynh

The federated image shareing service Pixelfed for YunoHost

https://pixelfed.org/

GNU Affero General Public License v3.0

44 stars 15 forks source link

Admin settings do not save correctly #172

Open azbulutlu opened 2 years ago

azbulutlu commented 2 years ago

Describe the bug

Some of the admin settings do not work correctly on a fresh install.

Context

Hardware: VPS bought online
YunoHost version: 4.3.6.3
I have access to my server: Through SSH
Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: no
Using, or trying to install package version/branch: 11.2

Steps to reproduce

Fresh install of pixelfed.
enabled admin interface as directed.

Expected behavior

Some settings can be changed, but others do not. (e.g. Branding instance title, long and short descriptions, about page headline, custom CSS)

The settings seems to be save, but when admin panel is refreshed it is clear changes were not reflected.

notes:

this is also referenced in the following issue upstream but putting it here as well as many of the cases mentioned seems to be yunohost related.

Some users can get partial fixes by chmoding some folders but not sure if this is the correct workaround.

lapineige commented 2 years ago

Thank you for raising this issue.

Some users can get partial fixes by chmoding some folders but not sure if this is the correct workaround.

This, and the fact that you are listing issues with variables defined in the .env config file, such as the instance title.

Right now the permissions seems to be read-only and the file owned by pixelfed user (group www-data). So indeed Pixelfed can't change it. sudo chmod 600 /var/www/pixelfed/.env should fix it. Can you confirm it does for you ?

azbulutlu commented 2 years ago

I am running into a bit of an issue testing this as now, when I chmod the views folder back to 770 (which it was at) it still works.

chmodding the .env file didn't do anything, I think this might be because the config cache overrides the .env file? (I remember reading that somewhere in the pixelfed github - which I think makes sense as I don't see the instance title long description and the short description at the .env file yet they are reflected on the live instance)

About and custom CSS still doesn't work (I can enable custom css but the content of the box resets).

sorry to be the bearer of bad news and thank you for looking into this. :)

lapineige commented 2 years ago

Then as I don't understand how this works I'm out of clue :sweat_smile:

azbulutlu commented 2 years ago

well both of us in this case. I am guessing the config cache is what gets updated when one does that artisan clear config cache line after each change. but where it is stored, I have no idea.

retiolus commented 10 months ago

Any news on this issue?

lapineige commented 10 months ago

Not from me.