YunoHost-Apps / pixelfed_ynh

The federated image shareing service Pixelfed for YunoHost
https://pixelfed.org/
GNU Affero General Public License v3.0
43 stars 15 forks source link

Default mail settings in .env do not work out of the box #228

Closed themancalledjakob closed 10 months ago

themancalledjakob commented 11 months ago

Describe the bug

Default mail settings in .env do not work out of the box.

Context

Steps to reproduce

sudo yunohost app install pixelfed
  1. Go to pixelfed instance with browser
  2. Create a new user and ask to send confirmation email
  3. “Something went wrong” - page opens

Expected behavior

Send confirmation email instead.

Proposal

Afaik there are two ways to solve this issue.

Option 1 - using sendmail

Either the default .env could be adjusted like so: https://github.com/themancalledjakob/pixelfed_ynh/blob/fix-mail-sendmail/conf/.env#L87

Option 2 - smtp with dedicated system user PR

or, the settings could be updated to fit in the new way of connecting apps with the mailserver as described here Which would probably be done like this: https://github.com/themancalledjakob/pixelfed_ynh/blob/fix-mail-smtp/manifest.toml#L45 and https://github.com/themancalledjakob/pixelfed_ynh/blob/fix-mail-smtp/conf/.env#L86-L94

the second option seems more elegant to me, as it follows yunohost instructions, possibly more future proof. the settings would have to be verified though, in my changes i am not sure whether port 25 or 587should be set. with the correct settings, i think this would be the way to go though.

@lapineige what do you think?

themancalledjakob commented 11 months ago

btw, i'm testing a fresh install with smtp via dedicated system user config right now to make sure it works

lapineige commented 10 months ago

Solved.