Fix php conf & image permissions

[lapineige]

223

PHP config was not done correctly, using extra_php.conf group wasn't overwriten correctly.

PR Status

• [x] Code finished and ready to be reviewed/tested
• [x] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[lapineige]

!testme

[yunohost-bot]

:rocket:

[lapineige]

!testme

[yunohost-bot]

Alrighty!

[lapineige]

Oh yes, thank you !

[lapineige]

!testme

[yunohost-bot]

Fingers crossed!

[Jaxom99]

Thanks for looking into it so quickly ! So if I read the test right, apart from the php_fpm settings that causes a linter error, all is good ? I can test on my setup anytime (just remind me how to switch branches to install this one ?)

[lapineige]

In my case, for an unknown reason this breaks image preview on upload. Don't test it now, it won't work :)

[lapineige]

(just remind me how to switch branches to install this one ?)

yunohost app upgrade pixelfed -u https://github.com/YunoHost-Apps/pixelfed_ynh/tree/fix_php_conf_image-permissions

[lapineige]

I was mistaken, it should work. You may try it :wink:

[lapineige]

!testme

[yunohost-bot]

Meow :cat2:

[lapineige]

I reverted to normal extra_php.conf, as the new option implemented by @alexAubin makes it way easier and cleaner to set the group for php workers. This should solve the issue for good.

[lapineige]

Thanks @alexAubin

[lapineige]

Here we go !

[Jaxom99]

wouhou, seems good for testing branch :wink: old posts fixed and new posts are ok. :+1: :1st_place_medal: :clap:

[lapineige]

Everything is back to normal, at last :)