Apply example_ynh - Githubissues

YunoHost-Apps / pixelfed_ynh

The federated image shareing service Pixelfed for YunoHost

https://pixelfed.org/

GNU Affero General Public License v3.0

44 stars 15 forks source link

Closed yalh76 closed 5 years ago

yalh76 commented 5 years ago

[x] Code review
[ ] Approval (LGTM)
Code review and approval have to be from a member of @YunoHost/apps group
CI succeeded :

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

Jibec commented 5 years ago

I don't see the added value of so many explicit parameters, but as you did the job... code looks good to me.

you probably should have moved the ynh_check_app_version_changed usage in another commit for readability reasons

yalh76 commented 5 years ago

I don't see the added value of so many explicit parameters, but as you did the job... code looks good to me.

I thinks it to make the scripts more readable :)

you probably should have moved the ynh_check_app_version_changed usage in another commit for readability reasons

Well, as is now integrated in example_ynh I implemented it directly :)