search

YunoHost-Apps / pixelfed_ynh

The federated image shareing service Pixelfed for YunoHost
https://pixelfed.org/
GNU Affero General Public License v3.0
44 stars 15 forks source link

Testing #61

Closed yalh76 closed 5 years ago

yalh76 commented 5 years ago

Solution

PR Status

Validation

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

lapineige commented 5 years ago

I have this issue:

Info: Reload the service php7.2-fpm Warning: Script @ php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1 Warning: Unable to update core dependencies with Composer. Warning: !! Warning: pixelfed's script has encountered an error. Its execution was cancelled

yalh76 commented 5 years ago

package:discover

weird because php artisan package:discover --ansi was already present in previous versions...

I have test manual upgrade from 0.9.0 and all was working...

I've added a package_check upgrade from actual master branch, Will wait for the test result.

yalh76 commented 5 years ago

I have this issue:

Info: Reload the service php7.2-fpm Warning: Script @ php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1 Warning: Unable to update core dependencies with Composer. Warning: !! Warning: pixelfed's script has encountered an error. Its execution was cancelled

Have you checked that : https://github.com/capistrano/laravel/issues/50#issuecomment-485172837

lapineige commented 5 years ago

ls config/ :

 app.php cache.php dotenv-editor.php horizon.php mail.php queue.php session.php auth.php costar.php filesystems.php image-optimizer.php partialcache.php recaptcha.php snowflake.php backup.php database.php hashids.php image.php pixelfed.php routes.php trustedproxy.php broadcasting.php debugbar.php hashing.php logging.php purify.php services.php view.php

yalh76 commented 5 years ago

Seems that there are file missing : https://github.com/pixelfed/pixelfed/tree/v0.9.0/config

like auth.php backup.php

lapineige commented 5 years ago

No they are all here.

lapineige commented 5 years ago

A normal upgrade works. There is an issue with this branch.

yalh76 commented 5 years ago

A normal upgrade works. There is an issue with this branch.

Very weird... I launched a package_check on two CI:

I will have to do manual upgrade tests and I will let you know

lapineige commented 5 years ago

Thanks a lot for your time and work :)

yalh76 commented 5 years ago

Well seems I found it: https://github.com/pixelfed/pixelfed/releases Capture

yalh76 commented 5 years ago

Just push a fix in the testing branch and launch some tests, if you can also test the upgrade ^^

lapineige commented 5 years ago

Upgrade works like a charm :)

lapineige commented 5 years ago

It's even better: now my Pixelfed federate with Mastodon 🎉 And some

By the way, a Jpeg image of only 1.6MB wasn't uploaded, because of a 413 Request entity too large. I had to modify Nginx config for pixelfed. I added client_max_body_size 100M; in my case.

Maybe we could directly change it here in the repo ? 1.6MB is really tiny for a picture… (even before Pixelfed internal conversion)