YunoHost-Apps / pixelfed_ynh

The federated image shareing service Pixelfed for YunoHost
https://pixelfed.org/
GNU Affero General Public License v3.0
44 stars 15 forks source link

Changing Where Images Are Stored #65

Closed StopTrackingUs closed 5 years ago

StopTrackingUs commented 5 years ago

This is a request to change where photos are stored to the /home folder. Peertube does this. I think it works great for those who set up pixelfed after they have already deployed yunohost for other purposes. The issue they could run into is the /var folder not having enough space, because by default debian makes home the biggest directory. For our server there is 3.6TB in /home and 95GB in /var lol. I didn't realize this until I started getting disk space notifications.

StopTrackingUs commented 5 years ago

The exact place of storage used by peertube is /home/yunohost.app/peertube/storage. Which is really handy with the issue above.

lapineige commented 5 years ago

Does symlinking the folder work ?

Maybe one could add on option during install (and then in a config file) that specify the storage folder. That would allow people to change it if needed, to their preferable location.

It's a good idea since Pixelfed is likely to require a lot of disk space.

(For instance in my case the biggest partition is /media, as I have an external storage)

yalh76 commented 5 years ago

@StopTrackingUs I agree with you and I have seen that when I repackaged peertube but the difference is that peertube configuration file provide a way to personalise storage:

and pixelfed doesn't provide that kind of functionality... Maybe you can open an issue to ask them to be able to choose storage location in the .env file. And when available we can implemnt it in pixelfed_ynh

I actually don't know where photos are currently stored :///

@lapineige

too much options kill options ;)

btw when we will move storage to /home/yunohost.app/pixelfed/storage, you would be able to move to the storage to your /media folder and make a symbolic link ;)

In conclusion, if you agree, as long as the option to choose the storage is not implemented in pixelfed I close this issue.

lapineige commented 5 years ago

too much options kill options ;)

Well, that's basically the same as configuring the .env (except it's easier for the non technical users ^^)

But I agree :)

yalh76 commented 5 years ago

Well, that's basically the same as configuring the .env (except it's easier for the non technical users ^^)

But non-technical users even don't what is a linux folder or which path to provide :p So this option would be more for mid-advanced users or lazy power root admins :ppp

StopTrackingUs commented 5 years ago

Well the issue for this admittedly lazy admin is that I have a pretty big peertube installation installed on the same server that has been running for almost a year. In order to resize the disk I have to take it off line. So requesting someone else do the work was my work around for not having down time lol.

But I can help with the set up. I would guess most people that are using yunohost as their first debian based system wouldn't realize in the installation process that they need a big var or to split between var and home.

StopTrackingUs commented 5 years ago

I talked to dansup and he said they are working on s3 support. Which I would expect would require implementations to be able to customize storage locations. I'll close this one. Let me know if I can pitch in on packaging or anything.

yalh76 commented 5 years ago

Well the issue for this admittedly lazy admin is that I have a pretty big peertube installation installed on the same server that has been running for almost a year. In order to resize the disk I have to take it off line. So requesting someone else do the work was my work around for not having down time lol.

But I can help with the set up. I would guess most people that are using yunohost as their first debian based system wouldn't realize in the installation process that they need a big var or to split between var and home.

Sorry you misunderstood me, the lazy power root admin was for @lapineige. for the option to choose the location during install. And for me being lazy for an IT is a quality :)

And I totally agree to move the storage to /home/yunohost.app/pixelfed/storage

And even me, as a linux beginner, I don't know what is the best setup for var and home... I just have one server in production for a non-profit organisation... and I haven't split home and var... all is in the same partition (I'm a very bad linux admin)

yalh76 commented 5 years ago

I talked to dansup and he said they are working on s3 support. Which I would expect would require implementations to be able to customize storage locations. I'll close this one. Let me know if I can pitch in on packaging or anything.

Good news :) I don't took the time to speak with upstream application maintainers