search

YunoHost-Apps / pixelfed_ynh

The federated image shareing service Pixelfed for YunoHost
https://pixelfed.org/
GNU Affero General Public License v3.0
44 stars 15 forks source link

Compose UI doesn't work #67

Closed lapineige closed 5 years ago

lapineige commented 5 years ago

The compose UI popup doesn't work (it was also the case with 0.9.0). The classical one works, but the other one let me upload the image, and after the 100% I have a pop-up "Oops, something went wrong".

I don't know if it's Yunohost or Pixelfed related.

yalh76 commented 5 years ago

Have you tryed from another browser ? or on another pixelfed instance ?

I just tested the compose ui and was able to upload a photo and post. Tested from:

lapineige commented 5 years ago

I've tested with Firefox 67 (linux), with extensions. And Tor Browser (linux too), without any extension. On this one it stays at 100% for a long time, then the same issue.

yalh76 commented 5 years ago

Can you provide your instance url and allow me to create an account to test from my computer ? or send the informations in a private message on mastodon or in a private room on matrix ?

raphgilles commented 5 years ago

I have this issue too on my Windows 10 + Firefox or Chrome

But it's working great with MacOS + Firefox or Chrome or Safari

yalh76 commented 5 years ago

Ok then, nothing consistent to help us understand what is the issue

lapineige commented 5 years ago

At least it doesn't seem to be a browser issue (I mean, not just with one browser), or extension related. Also tested with Firefox Nightly 69.

StopTrackingUs commented 5 years ago

Sorry I did not post this fix earlier. Thought it was just me.

I know the problem. You need to make a couple of updates. It will be required for all instance on yunohost (I now Believe). Fix by doing the following:

'sudo find / -name php.in' 'sudo nano /etc/php/7.2/fpm/php.ini' #update the file to be larger than 2 for max upload 'sudo nano /etc/php/7.0/fpm/php.ini' #update the file to be larger than 2 for max upload 'sudo systemctl restart php7.0-fpm' 'sudo systemctl restart php7.2-fpm'

Should be all good after that. The problem is that fpm has its own upload limit that is set. I can't figure out why this affects Pixelfed and not Peertube (probably because Peertube does no use fpm?) but once you update the max vars it will work perfectly.

yalh76 commented 5 years ago

instead of changing global php configuration, I propose to only change pixelfed php configuration.

Can you test it and let me know if it's OK ?

You can upgrade using : yunohost app upgrade pixelfed -u https://github.com/YunoHost-Apps/pixelfed_ynh/tree/testing

raspoutnik commented 5 years ago

I had the same issue, the upgrade solved it on my instance. Thanks !

lapineige commented 5 years ago

It worked :tada:

lapineige commented 5 years ago

So it seems that the new compose UI is using php limit, while the classic compose UI use nginx upload limit. That's good to know 🤔

StopTrackingUs commented 5 years ago

Yeah I noticed that on some uploads the new one used php-fpm and on others php.ini from the server. I couldn't tell until yesterday. @dansup helped me fix it from the upstream.

DeepinScreenshot_select-area_20190612143732 DeepinScreenshot_select-area_20190612143755 I just updated it on my server since our instance will be the only thing on our 2tb server.