search

YunoHost-Apps / pleroma_ynh

Pleroma package for YunoHost: A free, federated social networking server built on open protocols.
https://pleroma.social/
GNU Affero General Public License v3.0
30 stars 11 forks source link

Why substituting spaces in name with underscores? #182

Closed fflorent closed 2 years ago

fflorent commented 2 years ago

In installation script, we can see this line of code:

name="${YNH_APP_ARG_NAME// /_}"

I wonder why this substitution. If I edit the name in /etc/pleroma/config.exs directly, putting spaces in it, I don't get any error.

Is there any history around this? The reasons is still nowadays relevant?

Thanks :pray:

yalh76 commented 2 years ago

Hi,

Long story short: $name is used at https://github.com/YunoHost-Apps/pleroma_ynh/blob/e6d9935af254018baf326281662c55407170694d/scripts/install#L193-L213

And with spaces in the instance name, pleroma_ctl instance gen doesn't work... and I didn't find a way to find a solution other than removing spaces in the instance name ...