YunoHost-Apps / restic_ynh

Restic package for YunoHost
https://restic.net/
GNU Affero General Public License v3.0
6 stars 10 forks source link

Enable all kind of Restic repositories for backup #6

Closed pbernery closed 9 months ago

pbernery commented 3 years ago

This PR is not mergeable as is as it brakes existing configuration. This is currently for discussions.

This PR changes the package so that any Restic repository can be used for backups.

The changes are quite simple to make the package universal as the code was already made to use a simple Restic repository, I've just updated the Manifest so that a repository is asked to the user instead of the SFTP settings, and the install and update scripts.

These changes have some drawbacks though: this is less easy, or should I say out-of-the-box, to set up an SFTP backup. I chose to remove the SSH key generation because I think this should something to be done manually on the server after installation. In many case, I'm currently using Dropbox as a backup destination and I also have some setup to do (configure rclone in this case).

If this is still a desire to keep SFTP backup simple, an alternative could be to propose to generate it, through a checkbox for instance, or something more complex: a dropdown in which SFTP could be chosen, or Dropbox, and then special steps could be run when installing or updating.

ashemsay commented 3 years ago

Since the goal is to allow use of multiple repository types, it would be nice to have a few examples in the readme with the corresponding value to set for the repository setting.

ashemsay commented 3 years ago

Add ssh key generation in case of SFTP repository

pbernery commented 3 years ago

Hey. I've just seen that you made some feedbacks, sorry for the delayed answers.

pbernery commented 3 years ago

Since the goal is to allow use of multiple repository types, it would be nice to have a few examples in the readme with the corresponding value to set for the repository setting.

Right.

Add ssh key generation in case of SFTP repository

Alright.

I'll update the PR in the coming days.

ForsakenHarmony commented 2 years ago

This would be great to have

lapineige commented 9 months ago

What's the status of this PR ? :)

pbernery commented 9 months ago

I am no longer doing such backups, thus I cannot finalize this PR correctly, I will then close it.