search

YunoHost-Apps / roundcube_ynh

Roundcube package for YunoHost
https://roundcube.net/
GNU Affero General Public License v3.0
11 stars 22 forks source link

Level 5 forced #10

Closed maniackcrudelis closed 7 years ago

maniackcrudelis commented 7 years ago 
>>>> INSTALL SCRIPT <<<<
✘ At line 38 'ynh_die' or 'exit' command is executed with system modification before.
 This system modification is an issue if a verification exit the script.                                          
 You should move this verification before any system modification.                                                
✘ set -eu is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419

No system modifications before the line 38. set -eu replaced by ynh_abort_if_errors

>>>> REMOVE SCRIPT <<<<
✘ set -u is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419

No set -u, but using of ynh_secure_remove

>>>> UPGRADE SCRIPT <<<<
✘ set -eu is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419

set -eu replaced by ynh_abort_if_errors

>>>> BACKUP SCRIPT <<<<
✘ set -eu is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419

set -eu is at the line 10.

>>>> RESTORE SCRIPT <<<<
✘ At line 42 'ynh_die' or 'exit' command is executed with system modification before.
 This system modification is an issue if a verification exit the script.
 You should move this verification before any system modification.
✘ set -eu is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419

No system modifications before the line 42. set -eu is at the line 10.