[Fix] File upload limit with extra php-fpm conf

YunoHost-Apps / roundcube_ynh

Roundcube package for YunoHost

https://roundcube.net/

GNU Affero General Public License v3.0

11 stars 22 forks source link

[Fix] File upload limit with extra php-fpm conf #141

Closed grenagit closed 2 years ago

grenagit commented 2 years ago

Problem

The maximum size of attachments (PHP values upload_max_filesize) is not taken into account correctly.

ynh_add_fpm_config --usage=low --footprint=low does not take into account ./conf/php-fpm.conf

Solution

Delete ./conf/php-fpm.conf
Add ./conf/extra_php-fpm.conf

PR Status

[x] Code finished and ready to be reviewed
[x] The fix were manually tested

ericgaspar commented 2 years ago

superseded by #148

grenagit commented 2 years ago

@ericgaspar, despite #148 under YunoHost 11.0.9.6, the problem is still present...

The upload limit is always set to 2 MB because ynh_add_fpm_config --phpversion=$phpversion --usage=$fpm_usage --footprint=$fpm_footprint is usage 2 of ynh_add_fpm_config without template mode so ./conf/php-fpm.conf is no use!

Solution : Add ./conf/extra_php-fpm.conf which is added to the basic configuration!