Testing

[ericgaspar]

Problem

• Description of why you made this PR

Solution

• And how do you fix that problem

PR Status

• [ ] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[ericgaspar]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[ericgaspar]

!testme

[yunohost-bot]

:carousel_horse:

[ericgaspar]

!testme

[yunohost-bot]

May the CI gods be with you!

[ericgaspar]

!testme

[yunohost-bot]

:rocket:

[ericgaspar]

!testme

[yunohost-bot]

Alrighty!

[alexAubin]

!testme

[yunohost-bot]

Meow :cat2:

[ericgaspar]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[alexAubin]

At this stage i don't know what else to do but actually installing Roundcube locally and investigating what the hell happens when calling bin/update.sh (im even trying to read https://github.com/roundcube/roundcubemail/blob/master/bin/update.sh but can't understand how nor why composer is called exactly)

[CodeShakingSheep]

Just read about the update problem in this PR and it might be related to the kolab/net_ldap3 plugin. I had a similar problem 3 weeks ago when I tried to run composer.phar update manually and it happened because the git repository https://git.kolab.org/ where the mentioned plugin is hosted was down. If I remember correctly it was down for several days and until it was back up again I couldn't run the update command because it always timed out. See my comment on the issue here: https://github.com/roundcube/roundcubemail/issues/7416#issuecomment-1806520479

So, it might be worth a shot to run the tests again because now the git repository is up again.

[ericgaspar]

!testme

[yunohost-bot]

Alrighty!

[alexAubin]

Hmm I'm not sure this is the same issue, from what we can see on the CI, the script launches the bin/update.sh script, and then it hangs forever for seemingly no reason ...

Or maybe we need to upgrade to a newer version that contains the fix you mention if this is really the root cause of the issue

[nicofrand]

The issue comes from composer:

Info: [#################+..] > Updating roundcube configuration...
Warning: Do not run Composer as root/super user! See https://getcomposer.org/root for details
Warning: In Factory.php line 693:
Warning:   The HOME or COMPOSER_HOME environment variable must be set for composer to
Warning:   run correctly
Warning: update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>...]
Info: [##################+.] > Updating roundcube core...
Warning: Do not run Composer as root/super user! See https://getcomposer.org/root for details

When launched manually it is indeed interactive (even though -y is set).

root@nicofrand:/var/www/roundcube# ./bin/update.sh --version "1.6.0" -y
Executing database schema update.
Executing php composer.phar to update dependencies...
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Continue as root/super user [yes]? yes

[nicofrand]

Workaround to set before calling bin/update.sh:

export COMPOSER_ALLOW_SUPERUSER=1

Tested on my instance and the upgrade completed.

See https://getcomposer.org/doc/03-cli.md#composer-allow-superuser

[Salamandar]

Fixed o/

I'm testing the upgrade on my server then merging this.