YunoHost-Apps / roundcube_ynh

Roundcube package for YunoHost
https://roundcube.net/
GNU Affero General Public License v3.0
11 stars 19 forks source link

Possible incorrect group for config file #182

Open nicofrand opened 9 months ago

nicofrand commented 9 months ago

Describe the bug

Every file in config/ has a www-data a group but config/config.inc.php.

root@nicofrand:/var/www/roundcube# ls -la config/
total 96
drwxr-x---  2 roundcube www-data   4096 Sep 22 12:08 .
drwxr-x--- 14 roundcube www-data   4096 Sep 22 09:35 ..
-r--------  1 roundcube roundcube  7163 Sep 22 09:35 config.inc.php
-rw-r-----  1 roundcube www-data   2943 Jul 23  2022 config.inc.php.sample
-rw-r-----  1 roundcube www-data  63756 Jul 23  2022 defaults.inc.php
-rw-r-----  1 roundcube www-data    164 Jul 23  2022 .htaccess
-rw-r-----  1 roundcube www-data   2806 Jul 23  2022 mimetypes.php

Context

See https://github.com/YunoHost-Apps/roundcube_ynh/blob/master/scripts/install#L219

Expected behavior

config/config.inc.php has the www-data group like done here: https://github.com/YunoHost-Apps/roundcube_ynh/blob/master/scripts/install#L96

root@nicofrand:/var/www/roundcube# ls -la config/ total 96 drwxr-x--- 2 roundcube www-data 4096 Sep 22 12:08 . drwxr-x--- 14 roundcube www-data 4096 Sep 22 09:35 .. -r-------- 1 roundcube www-data 7163 Sep 22 09:35 config.inc.php -rw-r----- 1 roundcube www-data 2943 Jul 23 2022 config.inc.php.sample -rw-r----- 1 roundcube www-data 63756 Jul 23 2022 defaults.inc.php -rw-r----- 1 roundcube www-data 164 Jul 23 2022 .htaccess -rw-r----- 1 roundcube www-data 2806 Jul 23 2022 mimetypes.php