search

YunoHost-Apps / roundcube_ynh

Roundcube package for YunoHost
https://roundcube.net/
GNU Affero General Public License v3.0
11 stars 22 forks source link

Upgrade from 1.6.6~ynh2 to 1.6.7~ynh1 failed #201

Open rodinux opened 4 months ago

rodinux commented 4 months ago

Describe the bug

Upgrade to 1.6.7~ynh1 failed

Context

Steps to reproduce

Upgrade roundcube without failed

Logs

Here is the paste of the share logs

https://paste.yunohost.org/raw/foyisowage

The problem seems to appear with cardav plugin:

Warning: Here's an extract of the logs before the crash. It might help debugging the error:
Info: DEBUG -   - Removing phpunit/php-invoker (3.1.1)
Info: DEBUG -   - Removing phpunit/php-file-iterator (3.0.6)
Info: DEBUG -   - Removing phpunit/php-code-coverage (9.2.31)
Info: DEBUG -   - Removing phar-io/version (3.2.1)
Info: DEBUG -   - Removing phar-io/manifest (2.0.4)
Info: DEBUG -   - Removing nikic/php-parser (v5.0.2)
Info: DEBUG -   - Removing myclabs/deep-copy (1.11.1)
Info: DEBUG -   - Removing doctrine/instantiator (2.0.0)
Info: DEBUG - Generating autoload files
Info: DEBUG -
Info: DEBUG - In ClassMapGenerator.php line 129:
Info: DEBUG -
Info: DEBUG -   Could not scan for classes inside "/var/www/roundcube/vendor/roundcube/carddav/carddav.php" which does not appear to be a file nor a folder  
Info: DEBUG -
Info: DEBUG -
Info: DEBUG - install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--download-only] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [--audit] [--audit-format AUDIT-FORMAT] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]
Info: DEBUG -
Info: DEBUG - + ynh_die '--message=Unable to install core dependencies with Composer.'
Info: WARNING - Unable to install core dependencies with Composer.
Info: DEBUG - + ynh_exit_properly
rodinux commented 4 months ago

I effectively haven't a file /var/www/roundcube/vendor/roundcube/carddav/carddav.php, I am not sure have check the integration with the plugin Cardav at installation process...

bidroidk commented 3 months ago

Hello,

Upgrade also failed for me and it seems it is composer once again :-)

Describe the bug

Upgrade done via webadmin and failed (see logs)

Context

Steps to reproduce

Just try to upgrade roundcube via webadmin (I did not try with the cli).

Expected behavior

Roundcube upgrade with success :-)

Logs

You will find upgrade's log here : https://paste.yunohost.org/raw/rozowuvoxo

Thanks for you help !

bidroidk commented 2 months ago

Hello,

I am not aware of github action like pull request but I understood that you shipped version 1.6.7~ynh2 with some commits that may solved the failed upgrade ?

I try to upgrade roundcube today with no success. It seems due to a composer dependencies installation issue.

You cans find installation logs here : https://paste.yunohost.org/raw/evacahunox

I hope this helps.

Regards.

MadMan247 commented 2 months ago

EDIT: isn't this more relevant? https://github.com/YunoHost-Apps/roundcube_ynh/issues/193 you're using 1.6.0\~ynh4 and upgrading to 1.6.7\~ynh2. they're still working on a fix here: https://github.com/YunoHost-Apps/roundcube_ynh/pull/195. I still hold to make a backup, uninstall, reinstall. Backups should work, after all every time an install fails, a backup is used.

Hello, please understand this this is largely speculation, but I see this line: Required package "roundcube/archive" is not present in the lock file. and given that the most recent change was to change the installation file fromroundcube/archive/file.tar to roundcube/release/file.tar, did you try to upgrade to 1.6.7\~ynh1, restore back to 1.6.6\~ynh2, and then try to upgrade back to 1.6.7\~ynh2? or did you upgrade from 1.6.7\~ynh1 to 1.6.7\~ynh2?

Basically, I assume that the lock file was altered in your current installation. "This usually happens when composer files are incorrectly merged or the composer.json file is manually edited."

Could you please consider uninstalling roundcube and reinstalling from the application store? You shouldn't lose data doing this, but please ensure that you have a backup of the current installation before proceeding. Please let me know if you encounter the same issue.

bidroidk commented 2 months ago

Hello

Thanks for your answer

did you try to upgrade to 1.6.7~ynh1, restore back to 1.6.6~ynh2, and then try to upgrade back to 1.6.7~ynh2? or did you upgrade from 1.6.7~ynh1 to 1.6.7~ynh2?

I guess no. I am always using the web interface to upgrade application and I do not remember that kind of action

Could you please consider uninstalling roundcube and reinstalling from the application store? You shouldn't lose data doing this, but please ensure that you have a backup of the current installation before proceeding. Please let me know if you encounter the same issue.

I see your edit and understand that a work is still running on that issue. I have backups but I saw some posts (forum) where that it fails and I am a bit afraid :)

I will follow the issue #195 and try your solution in case of the issue does not solve the upgrade procedure.

Many thanks again

Regards