YunoHost-Apps / roundcube_ynh

Roundcube package for YunoHost
https://roundcube.net/
GNU Affero General Public License v3.0
11 stars 19 forks source link

Allow custom config #203

Open CodeShakingSheep opened 1 month ago

CodeShakingSheep commented 1 month ago

Problem

I am using 3 additional plugins in my roundcube instance. However, as I had to add them in config/config.inc.php after each update they get disabled and I have to enable them again manually (by adding the plugins back to config/config.inc.php which is annoying.

Solution

Instead of adding plugins to config/config.inc.php enable option to add them to a custom config file config/<ROUNDCUBE_DOMAIN>.inc.php by adding $config['include_host_config'] = true; to config/config.inc.php.

With this setting additional plugins can be enabled like this in config/<ROUNDCUBE_DOMAIN>.inc.php:

array_push($this->prop['plugins'], 'html5_notifier');

See https://github.com/roundcube/roundcubemail/issues/9458#issuecomment-2121753923.

I have it working like this on my server flawlessly.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

CodeShakingSheep commented 1 month ago

!testme

yunohost-bot commented 1 month ago

:books: Test Badge

yunohost-bot commented 1 month ago

:sunflower: Test Badge

ericgaspar commented 1 month ago

Please don't use the README.md file. The README is generated automatically with the description.md. You can use DESCRIPTION.md or ADMIN.md

CodeShakingSheep commented 1 month ago

Please don't use the README.md file. The README is generated automatically with the description.md. You can use DESCRIPTION.md or ADMIN.md

Thanks for the hint @ericgaspar . I reverted the commit for the README.md and made adoptions in ADMIN.md instead.