Change source back to release (was changed to archives)

e-jim commented 2 months ago

Problem

Fixes https://github.com/YunoHost-Apps/roundcube_ynh/issues/204 that was caused by commit https://github.com/YunoHost-Apps/roundcube_ynh/commit/dccb989e9d4334bb040e88677321dd387a3604f0#diff-06ac558c9cfca9e31a9a235f18d98e6d0c3bfee8bee0088108a29f2c60b318e3 that changed the source from releases file to archive file.

Solution

I set the source back to release files instead of archives of the repo

PR Status

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (on my own instance)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

e-jim commented 2 months ago

In my (very) humble opinion, it's a better solution than #211 as it doesn't add a new dependency.

MadMan247 commented 2 months ago

I just installed this branch, and it works like a charm. I wouldn't have thought that the archived releases would be different from the regular releases, other than being simply saved for later. What tipped you off?

And I 100% agree that this is a better solution than #211 - not even a question.

You're the goat, and I hope a maintainer or member of yunohost merges this pull request asap.

This fixes issues #200 #201 #204 and #210

Should probably be pushing this to the testing branch though. I'm not sure how strict they are on these things.

alexAubin commented 2 months ago

Eugarghr should have merged to testing ... will fix that

YunoHost-Apps / roundcube_ynh