YunoHost-Apps / roundcube_ynh

Roundcube package for YunoHost
https://roundcube.net/
GNU Affero General Public License v3.0
11 stars 22 forks source link

Fix upgrade #219

Open CodeShakingSheep opened 1 month ago

CodeShakingSheep commented 1 month ago

Don't replace config file

Problem

After the last update the contextmenu extension wasn't working anymore as the config/config.inc.php file had been overridden from the template file leading to the installed extensions not being present anymore after this line: https://github.com/YunoHost-Apps/roundcube_ynh/blob/master/conf/config.inc.php#L140

Solution

Keep config/config.inc.php and don't override it with the template.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

CodeShakingSheep commented 1 month ago

!testme

yunohost-bot commented 1 month ago

:sunflower: Test Badge

yunohost-bot commented 1 month ago

:books: Test Badge

CodeShakingSheep commented 1 month ago

!testme

yunohost-bot commented 1 month ago

Alrighty! Test Badge

yunohost-bot commented 1 month ago

:bug: Test Badge

CodeShakingSheep commented 1 month ago

!testme

yunohost-bot commented 1 month ago

May the CI gods be with you! Test Badge

yunohost-bot commented 1 month ago

:books: :bug: Test Badge

CodeShakingSheep commented 1 month ago

!testme

yunohost-bot commented 1 month ago

:book: Test Badge

yunohost-bot commented 1 month ago

Meow :cat2: Test Badge

CodeShakingSheep commented 1 month ago

Meow 🐈 Test Badge

Upgrades fail because of an already existing table collected_contacts. Created a PR for it https://github.com/sblaisot/automatic_addressbook/pull/31