[fix] stretch

[Rafi594]

Problem

• Install is broken on stretch

Solution

• Add php-zip as a dependence and remove jessie-backports

PR Status

Work finished. Could be reviewed and tested.

Validation

---

Minor decision

• Upgrade previous version :
• [x] Code review : Maniack C
• [x] Approval (LGTM) : Josué
• [x] Approval (LGTM) : Maniack C
• CI succeeded :
  When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

[maniackcrudelis]

I've fixed the upgrade script, that has been forgotten. However, seems strange that the restore script has nothing about deb packages ! But according to the CI, roundcube works well after a restore...

Did anyone who uses roundcube have tried a (real) restore of the package ?

[JimboJoe]

I've never tried myself (and I have no means to test for the next week), but as the dependency is related to LDAP, an error would maybe only occur at runtime when accessing the address book... and not in the CI?

[JimboJoe]

php-crypt-gpg package doesn't exist in stretch...

[JimboJoe]

@Rafi594 can you please look into my last question? Didn't you have a problem regarding php-crypt-gpg package?

[alexAubin]

Bumpity-bump ... un utilisateur sous Stretch a eu le probleme aujourd'hui de "roundcube a rajouté les backports sur mon systeme et ca cassé des trucs" :confused:

[frju365]

oui, normalement, il faudrait rajouter un PIN au dépôt.

[alexAubin]

Not sure I understand ? My understanding is just that he ran yunohost app install roundcube, which used the current version which does not have those fixes (and therefore, added the jessie backport repo, which cant be used at all on stretch, therefore triggering errors during apt-update)

So I was just pointing out that it would be nice to have progress on this PR :sweat_smile:

[maniackcrudelis]

Maybe we could try php-gnupg in replacement of php-crypt-gpg ? Is someone use gnugp and can try it ?

[JimboJoe]

I made some signing/encrypting tests without php-crypt-gpg on Stretch and... it works out of the box!

[JimboJoe]

Should be ready for review!

[alexAubin]

[alexAubin]

Bump guys, this PR needs some love ... People keep getting their setup broken on stretch because trying to install roundcube ... :confused:

[JimboJoe]

A code review is needed here... Unfortunately I've participated to the PR, so can't really review it... :blush:

[maniackcrudelis]

Code review OK. A new test is running on https://ci-apps-dev.yunohost.org/jenkins/job/roundcube_ynh%20PR35%20(Official_fork)/3/consoleFull

[maniackcrudelis]

Can be merged in 3 days