Closed JimboJoe closed 5 years ago
There is an important bug in master version (see https://forum.yunohost.org/t/roudcube-bouton-envoye-innactif-postfix-connection-refused/7614/11 ) I suggest to keep this testing small as possible to merge it quickly
I have reviewed the code. It seems ok.
For a strange reason install on subpath fail: https://ci-apps-hq.yunohost.org/jenkins/job/roundcube_ynh%20PR57/1/console
Looks like that PR has been forgotten. Or maybe it was on purpose?
Ready to be reviewed, if @JimboJoe agree.
I do agree :wink:
I was asking mainly because I think we do not have any feedback from this testing.
@zamentur the forum post here doesn't seem so positive about this upgrade...
Can be merged in 3 days
Bump folks, apparently this could be merged in 3 days, 15 days ago ? (Can I click the button :eyes: ? )
Sorry, but this is MY button.
@kay0u The button to post about the stable release in the roundcube dedicated thread on the forum is yours as well, I presume... :stuck_out_tongue_winking_eye:
It's done, sorry I never pushed that button before .
Problem
Solution
PR Status
Validation
Minor decision
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.