Roundcube: : Refactoring and upgrade to latest version

YunoHost-Apps / roundcube_ynh

Roundcube package for YunoHost

https://roundcube.net/

GNU Affero General Public License v3.0

11 stars 22 forks source link

Roundcube: : Refactoring and upgrade to latest version #7

Closed magikcypress closed 7 years ago

magikcypress commented 7 years ago

Following this PR

Major upgrade of Roundcube version
Package refactored to adjust to latest standards

Majeure decision Will be closed on August 7th, or July 17th if decision anticipated.

EDIT(frju365):Because it's set as major decision, we must do this ! :/ Major decision

[ ] Complete test :
[ ] Complete test :
[ ] Upgrade previous version :
[ ] Upgrade previous version :
[ ] Code review :
[ ] Code review :
[ ] Code review :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
[ ] CI succeeded : FAILED
[ ] CI succeeded :
[ ] CI succeeded :

JimboJoe commented 7 years ago

OK, now you need to focus on package_check results :wink:

alexAubin commented 7 years ago

Hi there,

any progress on this ? We have people regularly complaining about Roundcube install failing these days :/

https://forum.yunohost.org/t/issues-installing-roundcube-on/3202 https://github.com/YunoHost-Apps/roundcube_ynh/issues/6

Cheers !

frju365 commented 7 years ago

euh... Nobody care of roundcube ? This PR, as the package doesn't work at all, needs to be merge quickly ! :)

alexAubin commented 7 years ago

I'm guessing @magikcypress does somehow... @magikcypress , any chance you can give a summary of the situation ?

frju365 commented 7 years ago

I updated the PR summary... perhaps we can skip tests... as the package is not working yet and we need to merge it quickly ! (Can we set it, at least to medium decision ?)

maniackcrudelis commented 7 years ago

I just made a test, the upgrade script failed. And multi-instance install too. Not so bad for this part.

But as the previous version can't be install anymore, if the upgrade script doesn't work, it can be a real problem.

magikcypress commented 7 years ago

Sorry, I really don't any time for to work on this subject yet.

For me, I had to update correctly on a test machine with the latest version. But it is not an easy thing to propose it on stable?

When I tested the update from version 1.2.5 to 1.3.0 it worked., but It should be remembered that the version 1.2.3 in production.

To be sure that this works correctly, it would be necessary to install the old version of YunoHost, install roundcube in stable and make the update with this patch.

alexAubin commented 7 years ago

My 2 cents here, but I tested an install with this branch/repo on unstable and it worked.

JimboJoe commented 7 years ago

If I understand correctly, the 1.2.3 version can't be installed any more, but could be installed on an older version YunoHost, couldn't it? What "enhancement" in YunoHost rendered this application impossible to install, @magikcypress ? Otherwise, we can't really help on that PR as it is in your repository... Could you please push your changes in a branch in the official repository? Thanks!

frju365 commented 7 years ago

Can we close this PR as we have the other ?

maniackcrudelis commented 7 years ago

The other PR is under working for now. But if you want, just put a link between them.

maniackcrudelis commented 7 years ago

To be followed here https://github.com/YunoHost-Apps/roundcube_ynh/pull/9