Refactoring and upgrade to latest version - Local branch

maniackcrudelis commented 7 years ago

Problem

Package out of date
Doesn't work anymore on stable

Solution

Major upgrade of Roundcube version
Package refactored to adjust to latest standards

PR Status

Work finished
Package_check OK.
Basic tests OK.
Upgrade not tested. The previous version can't be installed.
Could be reviewed and tested.

Validation

~Medium decision~

[ ] ~Complete test :~
[ ] ~Upgrade previous version : not testable~
[X] ~Code review : JimboJoe~
[ ] ~Code review :~
[X] ~Approval (LGTM) : JimboJoe~
[ ] ~Approval (LGTM) :~
[ ] ~Approval (LGTM) :~
[X] ~CI succeeded : JimboJoe~
[ ] ~CI succeeded :~ ~One public package check log is enough instead of two checks.
When the PR is mark as ready to merge, you have to wait for 7 days before really merge it.~

Since this PR has been rerouted from master to testing. It passes to a minor decision.

[x] Upgrade previous version : not testable
[x] Code review : JimboJoe
[x] Approval (LGTM) : JimboJoe
[x] Approval (LGTM) : Aleks, Because we have to go forward !
[x] CI succeeded : JimboJoe When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

JimboJoe commented 7 years ago

Shouldn't we take advantage of this huge refactoring to adopt latest 2.7.2 standards (no sudo prefixes in every script, remove helpers)? As official apps are set as examples, I would say a clear YES :wink:

maniackcrudelis commented 7 years ago

Yes you're right, I forgot some residual sudo And, for the helpers, just I begin to work on these refactoring before the release. And my VM is not up to date...
I'm going to fix this on my side.
Feel free to edit this PR ;)

JimboJoe commented 7 years ago

And I also forgot to recommend to implement change_url scripts from now on ;-) So... you said the PR was ready, but I guess it's not really... :wink:

maniackcrudelis commented 7 years ago

I agree, it would be nice to implemente change_url scripts. But, for now, I will just make a refactoring, not any improvement. Because, we have 20 official apps, and I'm not the maintainer of these apps. So, I think it's would be great to have, at least, our apps with the last helpers and the correct shape.

JimboJoe commented 7 years ago

So... are we ready now for reviewing? :grinning:

maniackcrudelis commented 7 years ago

It's ok, we're ready ;)

alexAubin commented 7 years ago

Any update on this ? Is there any way we could test the update from a previous commit in the past or is there no hope at all because the old Composer install is broken anyway now ? (no idea how this all works)

alexAubin commented 6 years ago

People still regularly come complain on the support that roundcube is broken... Any chance that we can move forward with this ?

As far as my opinion counts, I'm okay with merging ASAP. I can try an install if that's really needed..

maniackcrudelis commented 6 years ago

@alexAubin Let's take your advise as the LGTM we're missing. And, we can merged it in 3 days in the testing branch

alexAubin commented 6 years ago

Agreed ! Cool, thanks :smile:

JimboJoe commented 6 years ago

Welcome to @alexAubin in the Apps Group! 🎉 More seriously, that's a pity we couldn't get a simple LGTM from the Apps Group in 3 weeks... We've got to learn from that for the other apps approval.

YunoHost-Apps / roundcube_ynh