YunoHost-Apps / rss-bridge_ynh

RSS-Bridge package for YunoHost
https://github.com/RSS-Bridge/rss-bridge
The Unlicense
14 stars 6 forks source link

Validate quality level 5 conformance #2

Closed JimboJoe closed 5 years ago

JimboJoe commented 7 years ago

This level needs to be formally assessed as there are residual warnings stated by package_linter:

>>>> INSTALL SCRIPT <<<<
✔ Only helpers are used
✔ no 'exit' command found: 'ynh_die' helper is possibly used
✔ Verifications (with 'ynh_die' or 'exit' commands) are done before any system modification.
✘ set -eu is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419
✔ Argument retrieval from manifest seems to be done with environement variables

This directive isn't needed as the ynh_abort_if_errors helper is used.

>>>> _COMMON.SH SCRIPT <<<<
✔ Only helpers are used
✘ Line 183: 'exit' command shouldn't be used. Use 'ynh_die' helper instead.

This corresponds to the ynh_exit_properly helpers that has been included in _common.sh until next YunoHost release including it.