search

YunoHost-Apps / rss-bridge_ynh

RSS-Bridge package for YunoHost
https://github.com/RSS-Bridge/rss-bridge
The Unlicense
14 stars 5 forks source link

Testing #21

Closed alexAubin closed 4 years ago

alexAubin commented 4 years ago

I savagely merged my previous cleaning PR into testing ... Now's the time to merge in master ...

As a reminder, the app is capped to level 4 because of old stuff instead of being level 7 ...

Last commit was tested in https://ci-apps-dev.yunohost.org/jenkins/view/aleks/job/rss-bridge_ynh%20(aleks)/lastBuild/console

JimboJoe commented 4 years ago

Hi, Thanks for the work! :heart: And sorry for my low responsivity... The upgrade is tested OK on my instance. I've made a quick code review, all is fine, except removed line 38 in remove script which seems missing...

Thanks again for your incredible amount of work! :heart_eyes:

alexAubin commented 4 years ago

I've made a quick code review, all is fine, except removed line 38 in remove script which seems missing...

That's because same thing is done line 31 right before :S

JimboJoe commented 4 years ago

Sorry, my bad, it was hidden by default in the Github review view... :blush: