search

YunoHost-Apps / rss-bridge_ynh

RSS-Bridge package for YunoHost
https://github.com/RSS-Bridge/rss-bridge
The Unlicense
14 stars 5 forks source link

Upgrade from php 7.3 to 8.0 #50

Closed Binnette closed 1 year ago

Binnette commented 1 year ago

Problem

PHP 7 have reached end of life: https://www.php.net/supported-versions.php

Solution

I upgraded this package to use PHP 8.

Note PHP 8 is supported by RSS-Bridge since version 2022-01-20. And this YNH package already have RSS-Bridge 2022.06.14.

I tested successfully this YNH package on my server.

PR Status

Automatic tests

@ericgaspar: can you please add me permissions to run !testme script? :heart:

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgaspar commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Fingers crossed! Test Badge

lapineige commented 1 year ago

Can we merge #51 in this one ?

Also CI is failing because the package sha256sum is no longer the same… did it change for a valid reason, or is there an upstream issue with the package delivery ? (hack, … ?)

lapineige commented 1 year ago

Replaced by #57 to avoid making you update to whole PR after #55. Feel free to contribute there if needed.