old settings were used, so it created new folders in the root dir
new directorys didn't get there configs
wrong service name for samba
"share" was named "shared" in the settings tags
old configs didn't get removed
Solution
fixed readonly and browsable
fix service name
update the share directory tag in install
WARNING
By fixing the share tag, the update needs a automatic migration for users, or it breaks the access to share folder if users use the config page.
If this pr dosnt go threw pleas remove the config page, its really broken.
Tests
I tested everything on my VM.
PR Status
[x] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)
Problem
Solution
WARNING
By fixing the share tag, the update needs a automatic migration for users, or it breaks the access to share folder if users use the config page. If this pr dosnt go threw pleas remove the config page, its really broken.
Tests
I tested everything on my VM.
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)