Testing

[Josue-T]

Problem

• App not up to date
• Packaging v1
• No bookworm compatibility

Solution

• Update package
• Rework packag with v2
• Add first support for bookworm

PR Status

• [x] Code finished and ready to be reviewed/tested
• [x] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[Josue-T]

!testme

[yunohost-bot]

Alrighty!

[Josue-T]

!testme !bookwormtestme

[yunohost-bot]

:books:

[yunohost-bot]

May the CI gods be with you!

[Josue-T]

!testme

[yunohost-bot]

:rocket:

[alexAubin]

Bit confused about the big pip stacktrace in the CI tho :

85885 WARNING    command: /opt/yunohost/seafile/venv/bin/python3 /tmp/tmpi3444kzz_in_process.py get_requires_for_build_wheel /tmp/tmpgm8re6j7
85885 WARNING        cwd: /tmp/pip-install-ecacok7y/mysqlclient_2ff6d65ab5b14300abad5bf96565ab24
85886 WARNING   Complete output (24 lines):
85886 WARNING   /bin/sh: 1: pkg-config: not found
85886 WARNING   /bin/sh: 1: pkg-config: not found
85886 WARNING   Trying pkg-config --exists mysqlclient
85886 WARNING   Command 'pkg-config --exists mysqlclient' returned non-zero exit status 127.
85886 WARNING   Trying pkg-config --exists mariadb
85886 WARNING   Command 'pkg-config --exists mariadb' returned non-zero exit status 127.
85887 WARNING   Traceback (most recent call last):
85887 WARNING     File "/tmp/tmpi3444kzz_in_process.py", line 280, in <module>
85887 WARNING       main()
85887 WARNING     File "/tmp/tmpi3444kzz_in_process.py", line 263, in main
85887 WARNING       json_out['return_val'] = hook(**hook_input['kwargs'])
85888 WARNING     File "/tmp/tmpi3444kzz_in_process.py", line 114, in get_requires_for_build_wheel
85888 WARNING       return hook(config_settings)
85888 WARNING     File "/tmp/pip-build-env-fo28mvd9/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 355, in get_requires_for_build_wheel
85888 WARNING       return self._get_build_requires(config_settings, requirements=['wheel'])
85889 WARNING     File "/tmp/pip-build-env-fo28mvd9/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 325, in _get_build_requires
85889 WARNING       self.run_setup()
85889 WARNING     File "/tmp/pip-build-env-fo28mvd9/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 341, in run_setup
85889 WARNING       exec(code, locals())
85889 WARNING     File "<string>", line 154, in <module>
85889 WARNING     File "<string>", line 48, in get_config_posix
85889 WARNING     File "<string>", line 27, in find_package_name
85890 WARNING   Exception: Can not find valid pkg-config name.
85890 WARNING   Specify MYSQLCLIENT_CFLAGS and MYSQLCLIENT_LDFLAGS env vars manually
85890 WARNING   ----------------------------------------
85891 WARNING WARNING: Discarding https://files.pythonhosted.org/packages/de/9c

[Josue-T]

Yes on bookworm, but the issue of installing pkg-config is conflicting with pkgconf. And if we decide to add one of theses requirement, on the current instance where the other package are installed, the install will fail because apt which try to remove the conflicting package and it's not allowed by yunohost...

On my install I had this error when I added this dependancy:

Reading package lists...
Building dependency tree...
Reading state information...
Correcting dependencies... Done
The following additional packages will be installed:
   libpkgconf3 pkgconf
 The following packages will be REMOVED:
   pkg-config
 The following NEW packages will be installed:
  libpkgconf3 pkgconf
0 upgraded, 2 newly installed, 1 to remove and 0 not upgraded.
 E: Packages need to be removed but remove is disabled.

And if we request pkgconf we will have some issue with instance when pkg-config is installed. And if we request pkg-config we will have some issue with instance when pkgconf is installed.

[Ddataa]

see issue https://github.com/YunoHost-Apps/seafile_ynh/issues/110

is this has been tested in a clean env ?