search

YunoHost-Apps / seafile_ynh

Seafile package for YunoHost
https://seafile.com
MIT License
14 stars 19 forks source link

Error when installing due to password containing ' char #30

Closed Clickb8 closed 6 years ago

Clickb8 commented 6 years ago

Hi, First, thank you for your work on this package. I had a problem when running the install script and using a complex password (like this one: sOIH&mU6q=&WRlMM-#'LxtH`d7\%ez). The install script fail:

Attention : -su: -c: ligne 0: caractère de fin de fichier (EOF) prématuré lors de la recherche du « ' » correspondant Attention : -su: -c: ligne 1: erreur de syntaxe : fin de fichier prématurée

It seems that you don't escape the user input correctly. Dunno how to fix this exactly...maybe by escaping correctly the chars or by warning the user that he can't use "special chars" (I'm not fan of this last solution for obvious security reason...)

Keep up with the good work !

Josue-T commented 6 years ago

Hello, Thanks for your report. It should be solved by the commit : 8209d4fbac38bbab6cfbe59063e23c19684863d0

I close this issue. If you have any more issue, please reopen it.