updgrade creates correct symlink to seafile-data

[katomaso]

Bugfix: update script was creating symbolic link to seafile-data inside wrong folder

lrwxrwxrwx 1 seafile seafile 31 Oct 26 11:21 /opt/yunohost/seafile/seafile-data/seafile-data -> /home/yunohost.app/seafile-data

Only one-level of seafile-data is required.

[Josue-T]

Hello,

Thanks for your PR. Well, we are theatrically in a really tricky case that it shouldn't happen. So I just trust you about this.

Can you just explain me what issue did you get and how you go in this case ?

[katomaso]

Hi, I was upgrading from 7.0.x to 7.1.x because of the broken WebDAV on restart.

sudo yunohost app upgrade seafile -u https://github.com/YunoHost-Apps/seafile_ynh/tree/7.1

Neither WebDAV nor web interface work now - that's annoying but not the point.

tail /opt/yunohost/seafile/logs/seafile.log 
[10/26/2020 11:21:34 AM] repo-mgr.c(894): Commit a4ba3582-d016-4cdc-9be1-30507f71a70e:cf2af8c49f346222afc6206c64705922d012327f is missing
[10/26/2020 11:21:34 AM] seafile-session.c(332): Failed to get system default repo. Create a new one.
[10/26/2020 11:21:35 AM] seafile-session.c(274): Failed to open template dir /opt/yunohost/seafile/seafile-data/library-template: Error opening directory “/opt/yunohost/seafile/seafile-data/library-template”: No such file or directory.
$ ls -al /opt/yunohost/seafile/seafile-data
lrwxrwxrwx 1 seafile seafile 31 Oct 26 11:21 /opt/yunohost/seafile/seafile-data/seafile-data -> /home/yunohost.app/seafile-data

So I moved the symlink one level up and put the exact commands I did it with into the upgrade script. The error message never occured again so I suppose it is correct now.

[katomaso]

Hmm, shouldn't here be mv /opt/yunohost/$app/seafile_data/* instead? This looks like we are loosing data on upgrade ...

[katomaso]

Hi, sorry that I ewnt forward with the fix. The current code was obviously wrong.

[Josue-T]

Thanks