Closed maniackcrudelis closed 7 years ago
For me the PR doesn't need a complete test. Upgrade is perhaps enough for the long tests category. For me :
I thought at a test of nginx. Try an install and check if nginx still works fine and if the panel appears.
Nice ;)
I would like to perform a pcheck test. But, currently this new method doesn't allow the dev who make the PR to check the boxes. I think we should think about that...
CI succeded is ok, no ?
LGTM 👍
CI succeded is ok, no ?
No, our CI doesn't check the pull request. So we have to perform this test on our own.
For what it's worth, I did a test. https://paste.yunohost.org/idojidubif
@maniackcrudelis If you're OK, we could merge that, couldn't we?
Yes we can, the upgrade test is not needed. We know that the nginx config will be rewrite by the upgrade.
2 PR at the same time, and we have duplicated this include. To works fine, this include need to be at the end of the file.
Minor decision, close on 13 of july, or 9 of july.