YunoHost-Apps / searx_ynh

Searx package for YunoHost
https://searx.github.io/searx/
GNU General Public License v3.0
20 stars 18 forks source link

Upgrade to upstream version 0.12.0 #16

Closed JimboJoe closed 6 years ago

JimboJoe commented 7 years ago

Problem

Upgrade to new Searx 0.12.0

Solution

Update upstream archive reference and adapt setting file.

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK. Could be reviewed and tested.

Validation

Since this PR has been rerouted from master to testing. It passes to a minor decision.

maniackcrudelis commented 7 years ago

Just 2 questions:

Anyway, I like your template for this PR. Maybe it's can be our official template. We need one, by the way...

So, I tried a "real" install on my VM, it works fine. And all the tests with Package check are good.

JimboJoe commented 7 years ago

As discussed on XMPP, it seems better to apply the complete process in the apps themselves, and then merge quickly the PR on official/community.json. So let's move on!

maniackcrudelis commented 7 years ago

If you don't mind, I slightlied change your the validation points. It seems more specific to the apps. Reverse my changes if you don't agree with me.

JimboJoe commented 6 years ago

Obsoleted by https://github.com/YunoHost-Apps/searx_ynh/pull/21