[enh] Update of the scripts

YunoHost-Apps / searx_ynh

Searx package for YunoHost

https://searx.github.io/searx/

GNU General Public License v3.0

20 stars 18 forks source link

[enh] Update of the scripts #18

Closed maniackcrudelis closed 6 years ago

maniackcrudelis commented 7 years ago

Problem

Scripts are a little bit out of date
Fix #19

Solution

Update of the scripts and helpers

PR Status

Work finished. Package_check OK.
Could be reviewed and tested.

Validation

Minor decision

[x] Upgrade previous version : Maniack C
[X] Code review : JimboJoe
[X] Approval (LGTM) : JimboJoe
[x] Approval (LGTM) : Scith
[X] CI succeeded : JimboJoe
[x] CI succeeded :
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

maniackcrudelis commented 6 years ago

@YunoHost-Apps/apps-group

maniackcrudelis commented 6 years ago

I would really try an upgrade (maybe tomorrow), but at least I can say our CI seems really happy to have your fix ! https://ci-apps-dev.yunohost.org/jenkins/job/searx_ynh%20global_update%20(Official)/2/consoleFull

maniackcrudelis commented 6 years ago

Because we can't install searx from the current stable version of this package, I just tried an upgrade from my own searx version. Quite a bit risky I know... But I'm confident about the work of JimboJoe, and I was right about it. The upgrade process works fine :)

scith commented 6 years ago

Looks good to me too 👍 Thanks for all your work refreshing the packages and bringing them up to standards

frju365 commented 6 years ago

I'm a bit late... but I approve this changes too.

maniackcrudelis commented 6 years ago

Will be merged in 3 days.