[enh] Fix is_public in lowercase or uppercase. - Githubissues

YunoHost-Apps / searx_ynh

Searx package for YunoHost

https://searx.github.io/searx/

GNU General Public License v3.0

20 stars 17 forks source link

[enh] Fix is_public in lowercase or uppercase. #25

Closed maniackcrudelis closed 6 years ago

maniackcrudelis commented 6 years ago

Problem

The fix of old is_public value doesn't work if is_public is in lowercase

Solution

Fix https://github.com/YunoHost-Apps/searx_ynh/issues/24
Compare without considering lowercase or uppercase.

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation

Minor decision

[x] Upgrade previous version : JimboJoe
[x] Code review : JimboJoe
[x] Approval (LGTM) : JimboJoe
[ ] Approval (LGTM) :
[x] CI succeeded :
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

maniackcrudelis commented 6 years ago

So... Let's merge in 3 days if everyone ok.

JimboJoe commented 6 years ago

Agreed!