Fix stretch

[maniackcrudelis]

Problem

• Searx can't be installed on stretch

Solution

• Modify the dependence python-pybabel to python-babel

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation

---

Minor decision

• [x] Upgrade previous version : JimboJoe
• [x] Code review : JimboJoe
• [x] Approval (LGTM) : JimboJoe
• [x] Approval (LGTM) : Josué
• CI succeeded :
  When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

[alexAubin]

Does it still work on jessie though ?

[maniackcrudelis]

Yes, sorry I forgot to say that I have also tried on jessie.

[JimboJoe]

Got this during upgrade (on Jessie):

+ sudo yunohost app setting searx checksum__etc_nginx_conf.d_ortest.noho.st.d_searx.conf --value=ebe9da51f76020e9990e1608c81657e4 --quiet
+ ynh_system_user_create searx
+ ynh_system_user_exists searx
+ getent passwd searx
+ rm -r /opt/yunohost/searx/lib/python2.7/site-packages/pip /opt/yunohost/searx/lib/python2.7/site-packages/setuptools /opt/yunohost/searx/lib/python2.7/site-packages/setuptools-38.2.4.dist-info /opt/yunohost/searx/lib/python2.7/site-packages/pip-9.0.1.dist-info
+ virtualenv --system-site-packages /opt/yunohost/searx
Overwriting /opt/yunohost/searx/lib/python2.7/site.py with new content
New python executable in /opt/yunohost/searx/bin/python
Warning: Traceback (most recent call last):
Warning:   File "/usr/local/bin/virtualenv", line 11, in <module>
Warning:     sys.exit(main())
Warning:   File "/usr/local/lib/python2.7/dist-packages/virtualenv.py", line 713, in main
Warning:     symlink=options.symlink)
Warning:   File "/usr/local/lib/python2.7/dist-packages/virtualenv.py", line 925, in create_environment
Warning:     site_packages=site_packages, clear=clear, symlink=symlink))
Warning:   File "/usr/local/lib/python2.7/dist-packages/virtualenv.py", line 1370, in install_python
Warning:     os.symlink(py_executable_base, full_pth)
Warning: OSError: [Errno 17] File exists

[maniackcrudelis]

Do you think it would be link to this PR ? Was it an upgrade from the current version to this PR ?

[JimboJoe]

Shouldn't be linked to this PR, and didn't have the chance to reproduce as I lost my VM...

[Josue-T]

Do you think it would be link to this PR ? Was it an upgrade from the current version to this PR ? Shouldn't be linked to this PR, and didn't have the chance to reproduce as I lost my VM...

I purpose to add a test of upgrade from an old version in the CI, it could be good to check if we can reproduce this bug.

[maniackcrudelis]

I purpose to add a test of upgrade from an old version in the CI, it could be good to check if we can reproduce this bug.

Feel free to update this PR with this test ;) However, that's the purpose of the test "Upgrade previous version". So it's done for this PR. But, if this option is added to the check_process, we can ignore this test.

[alexAubin]

Bumpity bump, any update on this ?

[maniackcrudelis]

We're still waiting for a last approval.

[maniackcrudelis]

Thanks Josue-T ;)

Will be merged in 3 days.

[maniackcrudelis]

Do you think guys that we need to ask to the community to try this testing release ? I don't think that it's going to affect anyone, would probably be better to wait for something more interesting to try.

[JimboJoe]

Agreed.