search

YunoHost-Apps / searx_ynh

Searx package for YunoHost
https://searx.github.io/searx/
GNU General Public License v3.0
20 stars 18 forks source link

use submodule for easier updates and set upstream to 0.10.0 #3

Closed ozzmos closed 7 years ago

M5oul commented 7 years ago

Great idea for submodule of subtree!

opi commented 7 years ago

I'm not a huge fan of using git submodules, as I think it makes it hard to find exacly which upstream version is used. Does using submodules download the whole repository history ?

Maybe I'm old-fashionned, but a good old wget https://github.com/asciimoo/searx/archive/v0.10.0.tar.gz within the install script is pretty straight forward to me ;)

But thanks anyway, I have to take some times to test your PR in both cases (install and update)

M5oul commented 7 years ago

Does using submodules download the whole repository history ?

Yep.

Maybe I'm old-fashionned, but a good old wget https://github.com/asciimoo/searx/archive/v0.10.0.tar.gz within the install script is pretty straight forward to me ;)

Agree with that, I prefer to download a release archive than sub{tree,module}.

ozzmos commented 7 years ago

@opi yes, it downloads the whole repository history. Inside the source directory, you can view logs, checkout for the searx project. I personally think it's easier for developers to test a specific version of Searx with submodule otherwise we need a branch for each searx version/install script. Furthermore a archive can always be removed or altered.

M5oul commented 7 years ago

it's easier for developers to test a specific version of Searx with submodule otherwise we need a branch for each searx version/install script.

Agree. But, I think, packages must stay on stable releases.

Furthermore a archive can always be removed or altered.

In fact, but it's a rare case.

Finally, I am ok about using sub{tree,module} or releases archives.

Releases archives could be less heavy as it doesn't contain git history.

zamentur commented 7 years ago

In 2.4.2, the current yunohost stable version, submodules are not supported by yunohost : see https://github.com/YunoHost/yunohost/pull/174 . Note with this PR all submodules history is downloaded. Subtrees are supported. An argument about subtrees, is that the package could be installed without internet (yunohost local network use case), but for searx it's not a really good reason.