Testing - Githubissues

YunoHost-Apps / searx_ynh

Searx package for YunoHost

https://searx.github.io/searx/

GNU General Public License v3.0

20 stars 17 forks source link

Testing #30

Closed maniackcrudelis closed 6 years ago

maniackcrudelis commented 6 years ago

Problem

The fix of old is_public value doesn't work if is_public is in lowercase
Searx can't be installed on stretch
App not up to date
The install on subpath is broken

Solution

Compare without considering lowercase or uppercase. #25
Modify the dependence python-pybabel to python-babel #28
Upgrade to 0.14.0
Use the uwsgi config from the upstream as documented here.
Fix #23

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : frju365
[x] Approval (LGTM) : frju365
[x] Approval (LGTM) : JimboJoe
CI succeeded :
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

maniackcrudelis commented 6 years ago

Ready to be reviewed

maniackcrudelis commented 6 years ago

Upgrade fails, this PR have to wait for https://github.com/YunoHost-Apps/searx_ynh/pull/31 before going forward...

JimboJoe commented 6 years ago

CI test re-launched, waiting for it to advertise the testing.

maniackcrudelis commented 6 years ago

I don't reproduce the 504 error on my VM. Maybe this new version is a little bit longer to start. We should try to add the helper to check the boot of the service.

JimboJoe commented 6 years ago

Yes, waiting for the effective end of start would be better. But for now, since you confirm it runs OK on your VM, I think we could release this testing. Up to you!

maniackcrudelis commented 6 years ago

Actually, I know that I have no time right now to do this modification. But I'm worried that we'd forget to fix that if we don't now. I could have a look at it on Friday, what do you think about waiting until then ?

JimboJoe commented 6 years ago

It's only in 3 days, so we really can wait :grinning:

frju365 commented 6 years ago

For me code review, LGTM ok. Just waiting a correct build of the CI ;)

maniackcrudelis commented 6 years ago

https://github.com/YunoHost-Apps/searx_ynh/pull/33

alexAubin commented 6 years ago

Bumpity bump, anybody has some courage to work on searx ? This PR is opened since two months :s

trillerpfeife commented 6 years ago

Also would like to use searx, at least get the python-pybabel #27 fixed. https://github.com/YunoHost-Apps/searx_ynh/pull/30/files#diff-ad962c6fd65b725b71aa46c8a715127fL58

JimboJoe commented 6 years ago

As I stated earlier, I'm OK with releasing this testing to at least have a "public" workaround. It would have been awesome if @trillerpfeife tested this release. This is the first case of a PR which is working fine, but freaking the CI out...

maniackcrudelis commented 6 years ago

anybody has some courage to work on searx ?

Work is (sometimes) ongoing on this PR, but I couldn't find a fix so far.

maniackcrudelis commented 6 years ago

Sorry, seems that I forgot this testing... Since that there's a lot of new commits, I dismiss the previous reviews from Josue-T and frju365.

This is now ready to be reviewed again ;)

maniackcrudelis commented 6 years ago

Also, since most of the commits are from me or Josue-T, I think we should expect reviews mainly from @JimboJoe and @frju365.

JimboJoe commented 6 years ago

Will be merged in 3 days.