Fix upgrade - Githubissues

YunoHost-Apps / searx_ynh

Searx package for YunoHost

https://searx.github.io/searx/

GNU General Public License v3.0

20 stars 17 forks source link

Fix upgrade #31

Closed maniackcrudelis closed 6 years ago

maniackcrudelis commented 6 years ago

Problem

Upgrade fails with error: "ImportError: No module named _internal"

Solution

Do not reinstall pip to avoid a conflict between pip versions.

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[ ] Code review :
[x] Approval (LGTM) : Josué
[ ] Approval (LGTM) :
CI succeeded :
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

JimboJoe commented 6 years ago

Isn't this PR already included in #32?

maniackcrudelis commented 6 years ago

Huh, yes it is. I probably cloned this PR to made the other one, in order to try the upgrade.

JimboJoe commented 6 years ago

So, as the other one will get merged, are you OK with closing this one?

maniackcrudelis commented 6 years ago

Yes, we can close this one as we merge the other one.

JimboJoe commented 6 years ago

Closing this PR as #32 got merged.

frju365 commented 6 years ago

I didn't understand, why merging this... or what did you mean by "close" . :-??

JimboJoe commented 6 years ago

Well I actually closed it, but the two PR seem linked somehow (14 update branch was probably created from fix_upgrade branch), hence that surprising "JimboJoe merged commit 284b297 into testing ".