Closed Josue-T closed 6 years ago
You can remove references to the PR #37, which is already fixed in testing, as well as add_ynh_check_starting.
I'm currently testing a commit (only on the dev CI) to decompose the line 97 on the install script. In order to have a clear log in case of others problem. As I did with the add_ynh_check_starting branch. I'll commit in this branch after the test if all goes well.
Anyway, GREAT JOB !!!
Code review OK
What about merging it in 3 day :P
Problem
Solution
Note that this PR include the PR #36
PR Status
Validation
Minor decision