Upgrade to upstream v0.15.0 and python3

YunoHost-Apps / searx_ynh

Searx package for YunoHost

https://searx.github.io/searx/

GNU General Public License v3.0

20 stars 17 forks source link

Upgrade to upstream v0.15.0 and python3 #41

Closed milouse closed 4 years ago

milouse commented 5 years ago

Problem

New upstream version 0.15.0
Current package use python2 and upstream may remove python2 support one day or another (asciimoo/searx#1471)

Solution

Replace virtualenv by virtualenv --python=/usr/bin/python3

PR Status

[X] Code finished.
[ ] Tested with Package_check (I'm not on debian/ubuntu :frowning_face:)
[X] Fix or enhancement tested.
[ ] Upgrade from last version tested.
[X] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[ ] Code review :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
CI succeeded :

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

Josue-T commented 5 years ago

The CI failled.

anmol26s commented 5 years ago

The upgrade from last version failed too. Will paste logs later today.

milouse commented 5 years ago

I add a new commit, trying to fix the upgrade problem. @anmol26s can you try again?

For the pathes problems, I must admit I'm not an expert of yunohost and don't know what happens. Any help will be appreciated ! Thanks

anmol26s commented 5 years ago

It is still failing. Log https://paste.yunohost.org/uxubexohad.go

milouse commented 5 years ago

Hi, your log is not complete. Could you copy/paste the content of the /root/.pip/pip.log file?

I'll try to do the test on my own. What is weird is that I succeeded to install it for me.

maniackcrudelis commented 5 years ago

I confirm that it doesn't work. 404 with Package_check and with a normal install.

milouse commented 5 years ago

I think I should rebase this PR on your branch @maniackcrudelis However I'll don't have time to do this before a while. Do not hesitate to take it over.

kay0u commented 5 years ago

Well, I tried to fix the issue, but I didn't succeed. I think the problem is this one:

https://github.com/asciimoo/searx/issues/1337

If someone want to look at this...

milouse commented 5 years ago

I don't remember if I modified nginx config files :/ I'll try to give a second look to this MR ASAP. Thank you for your help!

maniackcrudelis commented 4 years ago

We're actually already in version 0.15, following that PR https://github.com/YunoHost-Apps/searx_ynh/pull/52.

AkselRocks commented 4 years ago

yunohost still uses python 2 and not python 3. so it's not a clean update.

maniackcrudelis commented 4 years ago

Feel free to modify this PR, or to open a new one to migrate to python 3