Upgrade to python3 - Githubissues

YunoHost-Apps / searx_ynh

Searx package for YunoHost

https://searx.github.io/searx/

GNU General Public License v3.0

20 stars 17 forks source link

Upgrade to python3 #61

Closed Josue-T closed 3 years ago

Josue-T commented 4 years ago

Problem

Python 2 is depreciated
Using the same uwsgi systemd unit for all appliction is not a good practice.

Solution

Migrate to python3
Use the uwsgi helper to separate all applications

PR Status

[x] Code finished.
[x] Tested with Package_check.
[x] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[ ] Code review :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
CI succeeded :

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis commented 4 years ago

I do not see how this will fix #60 But anyway, to migrate to python3 is a good thing for this app.

However, last time it didn't work. And for now, It doesn't...

Josue-T commented 4 years ago

However, last time it didn't work. And for now, It doesn't...

Well only the upgrade from the old version fail. Everything else work...

I'll fix this

maniackcrudelis commented 4 years ago

Well only the upgrade from the old version fail. Everything else work...

And #60 is "Upgrade failed", but to says that the upgrade is a problem is obviously a minor problem

Josue-T commented 4 years ago

Yes if there are only one file which match.

maniackcrudelis commented 4 years ago

Yes if there are only one file which match.

I do not really feel relieved... It does not sound like a resilient way to remove the files !

I don't like that rm -r, which may be a rm only if there's only one file. But to use the helper knowing that it doesn't work correctly with regex. That doesn't sound like a good idea...

Josue-T commented 4 years ago

Yes if there are only one file which match.

I do not really feel relieved... It does not sound like a resilient way to remove the files !

I don't like that rm -r, which may be a rm only if there's only one file. But to use the helper knowing that it doesn't work correctly with regex. That doesn't sound like a good idea...

In this case we need to use something like rm -r $final_path/lib/python* || true

maniackcrudelis commented 4 years ago

You mean something to ignore an error if the file is nonexistent ? Like something that would "ignore nonexistent files" ?

So... -f

Josue-T commented 4 years ago

You mean something to ignore an error if the file is nonexistent ? Like something that would "ignore nonexistent files" ?

So... -f

As you want

maniackcrudelis commented 4 years ago

If I can find some extra time, a black hole would be useful, I'll have a look to include a way to manage regex into that helper.

maniackcrudelis commented 4 years ago

https://github.com/YunoHost-Apps/Experimental_helpers/blob/master/ynh_secure_remove_regex/ynh_secure_remove_regex

maniackcrudelis commented 4 years ago

To use that helper with the same name into the _common.sh won't work, as the helper is overwritten by source /usr/share/yunohost/helpers

Thatoo commented 4 years ago

could this update solve my issue https://github.com/YunoHost-Apps/searx_ynh/issues/62 ?

maniackcrudelis commented 4 years ago

Apparently last time we've tested this branch, the upgrade from a previous version wasn't working. So I don't think it would be a good idea for now to try it.