Testing : update to 0.12.0, nginx fix, other fixes

[lapineige]

57 : Updated to V0.12.0 and Nginx fix

59

[anmol26s]

Why is CI failing?

[lapineige]

@anmol26s I don't get it https://ci-apps-dev.yunohost.org/jenkins/job/shaarli_ynh%20PR58%20(ericgaspar)/lastBuild/console

[alexAubin]

@lapineige : uh yeah for some reason it looks like the CI fails to reach the app after the (successful) installation:

Try to access by url...
curl: (47) Maximum (50) redirects followed

Dunno if that's due to the CI somehow or if an human is able to reproduce the issue...

[ericgaspar]

You can implement the cURL post-install explained by Kayou on this issue for Mantis: https://github.com/YunoHost-Apps/mantis_ynh/pull/6 and the code: https://github.com/YunoHost-Apps/mantis_ynh/blob/e7a1f471d813a829558fe426aa21beb124f76727/scripts/install#L121-L137 This will skip the post installation panel

[lapineige]

I don't understand all of that, does it concerns only CI or this app too ?

[ericgaspar]

I think this is a problem with the NGINX config ...

[ericgaspar]

@lapineige I pushed Patch2 which should fix some errors Edit: the 302 is gone but the NGINX needs more work. It leeds to a white page. :/

[tituspijean]

So, I have investigated the issue with the Too many redirects. It happens due to Shaarli making the browser go back and forth between /install and /install/session-test. (I suspect it is a feature, not a bug, but I fail to see why they check for a session that way).

If we reinstate conf/config.json.php, the postinstall will be ignored and redirects loop will never be triggered. We need to update this file though, and put the placeholders seds (or --other_vars) back in install and upgrade.

[lapineige]

I'll trust you on this one, this is beyond my knowledge in yunohost packaging and nginx stuff. Just tell me when it's fixed :)

[tituspijean]

as of 9a949c1.

(cannot re-request a review, so let me ping @ericgaspar)