Testing - Githubissues

YunoHost-Apps / shaarli_ynh

Shaarli package for YunoHost

GNU General Public License v3.0

20 stars 13 forks source link

Testing #63

Closed ericgaspar closed 3 years ago

ericgaspar commented 3 years ago

Upgrade to version 0.12.1
Fix NGINX redirections
Remove pkg_dependencies
Fix upgrade script
reworked rights and permissions

PR Status

[x] Code finished.
[x] Tested with Package_check.
[ ] Fix or enhancement tested.
[ ] Upgrade from last version tested.
[ ] Can be reviewed and tested.

Package_check results

lapineige commented 3 years ago

Could we fix that bug #64 as well ? Sounds like a major issue for our users who would like to upgrade :/

ericgaspar commented 3 years ago

Could we fix that bug #64 as well ? Sounds like a major issue for our users who would like to upgrade :/

The upgrade script, as is, reinstalls the application folder from source before copying the data and the tpl file to a temporary directory, because of that, data and settings from the previous installation are lost. :/

733cfdc should adress that issue.

I have also reworked rights and permissions (as advised in the Shaarli documentation page) as follow:

chown -R $app: $final_path
chmod -R g+rX $final_path
chmod -R g+rwX $final_path/{cache/,data/,pagecache/,tmp/}

ping: @tituspijean

lapineige commented 3 years ago

I have also reworked rights and permissions (as advised in the Shaarli documentation page) as follow:

@ericgaspar Am I correct if I say that this fixes https://github.com/YunoHost-Apps/shaarli_ynh/pull/54#discussion_r410200542 ? (and as a result, https://github.com/YunoHost-Apps/shaarli_ynh/issues/55)

ericgaspar commented 3 years ago

I have also reworked rights and permissions (as advised in the Shaarli documentation page) as follow:

@ericgaspar Am I correct if I say that this fixes #54 (comment) ? (and as a result, #55)

Yes, I guess so.