No idea if this is actually better but it sounds simpler to me to just rely on sha1sum than calling and evaluating php code ... Imho there's less possibility for funky stuff happening related to special chars in passwords
PR Status
[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)
lapineige
commented
2 years ago
Problem
cf https://forum.yunohost.org/t/installation-de-shaarli-impossible/21031/2
Solution
No idea if this is actually better but it sounds simpler to me to just rely on
sha1sumthan calling and evaluating php code ... Imho there's less possibility for funky stuff happening related to special chars in passwordsPR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)