search

YunoHost-Apps / shaarli_ynh

Shaarli package for YunoHost
GNU General Public License v3.0
20 stars 13 forks source link

Testing #92

Closed alexAubin closed 6 months ago

alexAubin commented 7 months ago

!testme

yunohost-bot commented 7 months ago

:v: Test Badge

lapineige commented 7 months ago

Isn't that helper supposed to work around existing files ? 😅

alexAubin commented 7 months ago

Yeah hmpf I remember a stupid story about how the log is supposed to end in .log and not .txt otherwise it assumes it's supposed to be a folder \~_\~

lapineige commented 7 months ago

Naive question : what's wrong with the current syntax of the helper ? (if it work 😄)

alexAubin commented 7 months ago

It doesnt, the official CI shows:

48493 INFO [#####+++++..........] > Adding system configurations related to shaarli...
54594 WARNING /usr/share/yunohost/helpers.d/logrotate: line 63: [: -u shaarli: integer expression expected

and if you look at the detailed log, the parsing of the argument is completely fucked up and I very much doubt that any log rotation actually happens

lapineige commented 7 months ago

Ok then it's a big deal :( Thank you :)

alexAubin commented 6 months ago

Issue related to .txt to be fixed in next core release, cf https://github.com/YunoHost/yunohost/commit/308ed0e1742f405fb2b7ce38d75b707d6dcc90e9 ...

lapineige commented 6 months ago

Nice ! Is it ready for CI then ? Should we update the manifest ?

alexAubin commented 6 months ago

Yes we should update the manifest, but the new version aint released yet

alexAubin commented 6 months ago

CI now runs 11.2.9 which includes a refactoring of the logrotate madness, should fix the issue

!testme

alexAubin commented 6 months ago

!testme

yunohost-bot commented 6 months ago

:stuck_out_tongue_winking_eye: Test Badge