Testing - Githubissues

YunoHost-Apps / shellinabox_ynh

Shell In A Box package for YunoHost

GNU General Public License v3.0

7 stars 3 forks source link

Testing #11

Closed maniackcrudelis closed 6 years ago

maniackcrudelis commented 6 years ago

Problem

--disable-ssl is missing in /etc/default/shellinabox after an upgrade.

Solution

Rewrite config during the upgrade
Fix https://github.com/YunoHost-Apps/shellinabox_ynh/issues/9

PR Status

[x] Code finished.
[x] Tested with Package_check.
[x] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : JimboJoe from #10
[x] Approval (LGTM) : JimboJoe from #10
[x] Approval (LGTM) : Josué from #10
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis commented 6 years ago

Ready to be reviewed

maniackcrudelis commented 6 years ago

Can be merged in 3 days, if no one's opposed to.

JimboJoe commented 6 years ago

:+1: