Testing - Githubissues

YunoHost-Apps / shellinabox_ynh

Shell In A Box package for YunoHost

GNU General Public License v3.0

7 stars 3 forks source link

Closed JimboJoe closed 5 years ago

JimboJoe commented 5 years ago

Minor decision

Upgrade previous version :
[x] Code review : Kay0u
[x] Approval (LGTM) : Kay0u
[ ] Approval (LGTM) :
CI succeeded : When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

JimboJoe commented 5 years ago

As discussed here, proposing to wait for a functional change before advertising a testing release.

kay0u commented 5 years ago

Change url is not a "Functional change"?

maniackcrudelis commented 5 years ago

Yep it is Ready for review

kay0u commented 5 years ago

Can be merged in 3 days?

maniackcrudelis commented 5 years ago

Aleks isn't a member of apps group. But anyway, should we really wait more for an like this one...?

kay0u commented 5 years ago

As you are not the author of this PR, you can add a LGTM too if you want ;-)

JimboJoe commented 5 years ago

And I'm the author of the PR, but not of the code so... LGTM? :slightly_smiling_face:

kay0u commented 5 years ago

Ok, can be merged in 3 days then!