Upgrade fails: from 2.21~ynh3 to 2.21~ynh4

jcn50 commented 1 year ago

Describe the bug

Cannot upgrade.

Context

Hardware: VPS bought online (same on 2x different servers)
YunoHost version: 11.1.20
I have access to my server: Through SSH | through the webadmin
Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: no
Using, or trying to install package version/branch: 2.21~ynh4
If upgrading, current package version: 2.21~ynh3

Steps to reproduce

Using the webadmin update.

Logs

https://paste.yunohost.org/raw/ocuzimiper

skyuk3000 commented 1 year ago

Getting the same issue,

After checking the manifest.toml, it seems that some resources are missing. Not sure why they are needed when they are blank.

[resources]
    [resources.system_user]

    [resources.install_dir]

    [resources.data_dir]

rmueck commented 1 year ago

Same issue here,

Logs:

https://paste.yunohost.org/raw/eduyebahab

noccio commented 1 year ago

Thread on the forum https://forum.yunohost.org/t/shellinabox-little-bug-in-upgrade/25173

webmink commented 1 year ago

I and others have the same issue, reported in that thread, happy to supply info.

jcn50 commented 1 year ago

@ericgaspar any update bro?

MayeulC commented 11 months ago

Same issue here, I had it for a long time, but decided to dig a bit more today.

3373 DEBUG Checking that required services are up and running...
4648 INFO Deprovisionning install_dir...
4649 INFO Deprovisionning system_user...
userdel: user shellinabox is currently used by process 2120
/usr/sbin/deluser : « /usr/sbin/userdel shellinabox » a retourné le code d'erreur 8. Abandon.
4740 WARNING Failed to deprovision system_user : Failed to delete system user for shellinabox
4740 INFO Reprovisionning install_dir...
4747 INFO Reprovisionning system_user...

It turns out it tries to delete a system user in use by a process. Doing ps -A |grep 2120 informed me that the offending process was shellinaboxd.

Thus: shellinabox can be upgraded by first stopping the service: systemctl stop shellinabox, then performing the yunohost upgrade.

Edit: it deletes the user, but does not recreate it. Shellinabox cannot start after the upgrade anymore, so I uninstalled it and reinstalled it.

noccio commented 11 months ago

I could "upgrade" the program first removing, then re-installing and adding some group to use shellinabox

webmink commented 11 months ago

I found I could not remove/reinstall, the problem persisted, and that stopping the daemon allowed an "upgrade" but then the daemon failed to launch complaining it could not find the system user. I have removed shellinabox and switched to wetty.

YunoHost-Apps / shellinabox_ynh