search

YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost
https://matrix.org/
GNU General Public License v3.0
79 stars 42 forks source link

Riot forces me connecting via SSO #195

Closed Thovi98 closed 4 years ago

Thovi98 commented 4 years ago

Since latest update of synapse_ynh (I think so, but I didn't try new connections in recent days before it), I'm forced to connect via sso with my main user of Yunohost.

I explain : When I go to https://riot.im/app/#/login (and also on the login screen of the Riot desktop app), server is set on matrix-client.matrix.org and I can connect with username and password.

But that's not what I want, because I've my own Yunohost server. So I change matrix-client.matrix.org to my Yunohost domain name. But before, I was able to connect to it (or create an account) with my username and password (like on matrix.org server) ; now I've only one button with "Sign in with single sign-on" or "create account" (which does the same as signing-in with single sign-on.

So I'm still able to use my account in already connected Riot apps, but I cannot in apps or webpages that I want to first time connect.

Sorry for my English, I don't know if it is comprehensible.

Do I something wrong ?

Thanks for this awesome package that I discovered about one month ago, and that I enjoy a lot !! :D

Josue-T commented 4 years ago

Hello,

Yes there was some change in synapse. Before the SSO was integrated in Riot with a really dirty patch because riot and synapse didn't supported the SSO. Now this is implemented on Riot and synapse and we migrated to the official implementation of the SSO.

But well, I don't really understand your issue. Normally you should be able to click on "Sign in with single sign-on" and you should follow some redirection and after you should be authenticated without problem. So did you try to click on "Sign in with single sign-on" ? And what is happening if you click on this ?

Josue-T commented 4 years ago

Ah Ok, I understand. So I think that you set this app instance as public ? Is it true. Maybe the solution could be to disable the SSO if the app is public.

Thovi98 commented 4 years ago

Yes, I set it as public. Yes, great idea ! Thanks :D

Josue-T commented 4 years ago

Should be fixed on the testing branch. You can upgrade with:

sudo yunohost app upgrade synapse -u https://github.com/YunoHost-Apps/synapse_ynh/tree/testing
Thovi98 commented 4 years ago

Waouh you are amazing ! It works like a charm now, thanks for your package and your fast support :D

Is it safe now to stay on the testing branch, or do I have to do something to return on the stable branch later ?

Josue-T commented 4 years ago

You won't use the testing any more if you don't specify to use it.

Thovi98 commented 4 years ago

Oh okay nice, so everything is clear now, thanks ! I think we can close the issue.

tompatulpan commented 4 years ago

yeah, testing repo working here too.

mailtrix commented 4 years ago

Hello, is an update planned for the stable version?

Josue-T commented 4 years ago

In view days Yes. About 5-6 days.

mailtrix commented 4 years ago

Great! Thank you very much!

jchammons commented 4 years ago

I can confirm this is good on my system. Thank you!

ghost commented 4 years ago

Well then we can close this issue or?

Josue-T commented 4 years ago

When the fix will be available in master.

Josue-T commented 4 years ago

Should be fixed now