search

YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost
https://matrix.org/
GNU General Public License v3.0
79 stars 42 forks source link

Switch to matrix.to link #294

Closed chmac closed 1 year ago

chmac commented 2 years ago

The matrix.to site allows users to click matrix links into many clients, while the previous link is the web version of the riot.im client, which I think has by now been renamed to element also.

chmac commented 2 years ago

@ericgaspar I accepted your proposed changes, didn't know that was possible on GitHub, neat feature. But somehow the review still shows as "1 change requested" and I don't see how to mark that change as made.

Nice catch on the libera.chat domain instead of matrix.org btw.

ericgaspar commented 2 years ago

https://riot.im/app/#/room/#yunohost:matrix.org seems to be the legit address to access the chat.

chmac commented 2 years ago

@ericgaspar Can you expand on what you mean by "legit"?

Matrix is a federated protocol. The ID of the room is #yunohost:matrix.org or #yunohost:libera.chat. When I load either of those rooms in my matrix client, the description of the room says "please use #yunohost:libera.chat. Additionally, the #yunohost:libera.chat room has 407 members vs #yunohost:matrix.org which has only 380.

The domain riot.im redirects to element.io because the software Riot has been renamed to Element.

The link riot.im/app/... is a link to the web version of Element. Personally I use a desktop app instead of a web version. So that link does not work for me. While the matrix.to service takes a room ID and offers links to multiple clients. Specifically it says:

Create shareable links to Matrix rooms, users or messages without being tied to any app

So given all of this, I think that the https://matrix.to/#/#yunohost:libera.chat link is more appropriate than the riot.im version.

MayeulC commented 2 years ago

I agree that the link should be a matrix.to link, but I am not sure where it should point.

@ericgaspar Can you expand on what you mean by "legit"?

@chmac There are a few misconceptions here. Reading this guide on bridging might help.

Matrix is a federated protocol. The ID of the room is #yunohost:matrix.org or #yunohost:libera.chat.

These are not room IDs, they are aliases. Think pointers or symbolic links. These two rooms are different.

The first one is a plumbed room. The second one is a portal room. They're handled slightly differently, though I am not sure what the current state is.

A plumbed room is a Matrix room that has been connected to another chat network via an app service. It is designed to be administrated from the Matrix side, it's "matrix native".

A portal room is mostly useful when there is no plumbed room. In this case, rooms are generated automatically when attempting to view a libera.chat room, and is really administered by IRC/libera admins.

Member count is irrelevant, bridges usually show new users on the other side only when they first talk.

A plumbed room has a few advantages. Among them, it can be unlinked and re-linked to the IRC room, or another (possibly on another server). I have been suggesting multiple times the plumbed room be made the main one. It would have helped during the libera.chat migration. Plumbed rooms can be upgraded too. m.tombstone events allow to close a room and point to a new one, this could be used to merge the two, but I am not sure if it is possible to send in the portal room.

chmac commented 2 years ago

@MayeulC Thanks for the detailed info. I'm familiar with the matrix side of things, but not with the yunohost setup. I think it would make sense to change the link and to standardise the decision across the room topic and the website. But that's a decision beyond my involvement. It seems clear to me, and I assume everyone involved, that my PR improves the situation. I'm sure more improvements are also possible.

Personally, I have no association to yunohost, I just saw this randomly one day and figured it would be quick and easy to submit a PR.

MayeulC commented 2 years ago

I agree that replacing the riot.im link with a matrix.to link improves things.

However, you also change the room it points to, which is a whole other can of worms to open :/

I am not sure anyone agrees what the cannonical yunohost room is on Matrix, I would have to ask around.

chmac commented 2 years ago

@MayeulC Oh yeah, true. I forgot about that honestly. It's a very simple change, and I submitted the PR in January! I figured that if the room should stay the same, somebody can also make that change. Given that the channel topic says "please use this room", I figured that was the correct room, but of course that info could also be wrong.

Anyway, I'll bow out of the discussion as I have really no useful input to offer on the yunohost front, and it seems like @MayeulC has nicely explained the matrix side of things.

Linkid commented 1 year ago

Hello. In the Yunohost website, the link for matrix is #yunohost:matrix.org (https://github.com/yunohost/doc/blob/master/pages/05.community/10.chat_rooms/chat_rooms.md?plain=1#L23). Maybe you should keep it like that for your current PR, as it is not the main subject.

Linkid commented 1 year ago

You can also update the link here:

tituspijean commented 1 year ago

Minor change, merging directly to testing.